Commit e66c3184 authored by SeongJae Park's avatar SeongJae Park Committed by Wen Zhiwei
Browse files

mm/damon/core: copy nr_accesses when splitting region 

stable inclusion
from stable-v6.6.63
commit 62aec1e925996a358dbfc08daf5ec26243bbafd0
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IBI1RP

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=62aec1e925996a358dbfc08daf5ec26243bbafd0

--------------------------------

commit 1f3730fd9e8d4d77fb99c60d0e6ad4b1104e7e04 upstream.

Regions split function ('damon_split_region_at()') is called at the
beginning of an aggregation interval, and when DAMOS applying the actions
and charging quota.  Because 'nr_accesses' fields of all regions are reset
at the beginning of each aggregation interval, and DAMOS was applying the
action at the end of each aggregation interval, there was no need to copy
the 'nr_accesses' field to the split-out region.

However, commit 42f994b71404 ("mm/damon/core: implement scheme-specific
apply interval") made DAMOS applies action on its own timing interval.
Hence, 'nr_accesses' should also copied to split-out regions, but the
commit didn't.  Fix it by copying it.

Link: https://lkml.kernel.org/r/20231119171529.66863-1-sj@kernel.org


Fixes: 42f994b71404 ("mm/damon/core: implement scheme-specific apply interval")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent 467a8fc9

mm/damon/core.c

+1 −0
Original line number Diff line number Diff line
@@ -1215,6 +1215,7 @@ static void damon_split_region_at(struct damon_target *t, 


	new->age = r->age;

	new->last_nr_accesses = r->last_nr_accesses;

	new->nr_accesses = r->nr_accesses;



	damon_insert_region(new, r, damon_next_region(r), t);

}