Commit e666a4c6 authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'drivers-net-warning-clean' 



Jesse Brandeburg says:

====================
make drivers/net/ethernet W=1 clean

The Goal: move to W=1 being default for drivers/net/ethernet, and
then use automation to catch more code issues (warnings) being
introduced.
The status: Getting much closer but not quite done for all
architectures.

After applying the patches below, the drivers/net/ethernet
directory can be built as modules with W=1 with no warnings (so
far on x64_64 arch only!). As Jakub pointed out, there is much
more work to do to clean up C=1, but that will be another series
of changes.

This series removes 1,247 warnings and hopefully allows the
ethernet directory to move forward from here without more
warnings being added. There is only one objtool warning now.

This version drops one of the Intel patches, as I couldn't
reproduce the original issue to document the warning.

Some of these patches are already sent and tested on Intel Wired
Lan, but the rest of the series titled drivers/net/ethernet
affects other drivers. The changes are all pretty
straightforward.
====================

Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarSaeed Mahameed <saeed@kernel.org>
parents d0186842 d0ea5cbd

drivers/net/ethernet/amazon/ena/ena_com.c

+1 −1
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ static int ena_com_wait_and_process_admin_cq_polling(struct ena_comp_ctx *comp_c 
	return ret;

}



/**

/*

 * Set the LLQ configurations of the firmware

 *

 * The driver provides only the enabled feature values to the device,

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c

+1 −1
Original line number Diff line number Diff line
@@ -1536,7 +1536,7 @@ static int hw_atl_b0_hw_fl2_clear(struct aq_hw_s *self, 
	return aq_hw_err_from_flags(self);

}



/**

/*

 * @brief Set VLAN filter table

 * @details Configure VLAN filter table to accept (and assign the queue) traffic

 *  for the particular vlan ids.

drivers/net/ethernet/arc/emac_arc.c

+1 −1
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-or-later

/**

 * emac_arc.c - ARC EMAC specific glue layer

 * DOC: emac_arc.c - ARC EMAC specific glue layer

 *

 * Copyright (C) 2014 Romain Perier

 *

drivers/net/ethernet/atheros/atl1c/atl1c_main.c

+5 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ static u32 atl1c_wait_until_idle(struct atl1c_hw *hw, u32 modu_ctrl) 


/**

 * atl1c_phy_config - Timer Call-back

 * @data: pointer to netdev cast into an unsigned long

 * @t: timer list containing pointer to netdev cast into an unsigned long

 */

static void atl1c_phy_config(struct timer_list *t)

{
@@ -346,6 +346,7 @@ static void atl1c_del_timer(struct atl1c_adapter *adapter) 
/**

 * atl1c_tx_timeout - Respond to a Tx Hang

 * @netdev: network interface device structure

 * @txqueue: index of hanging tx queue

 */

static void atl1c_tx_timeout(struct net_device *netdev, unsigned int txqueue)

{
@@ -846,6 +847,7 @@ static inline void atl1c_clean_buffer(struct pci_dev *pdev, 
/**

 * atl1c_clean_tx_ring - Free Tx-skb

 * @adapter: board private structure

 * @type: type of transmit queue

 */

static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter,

				enum atl1c_trans_queue type)
@@ -1861,6 +1863,8 @@ static void atl1c_clean_rx_irq(struct atl1c_adapter *adapter, 


/**

 * atl1c_clean - NAPI Rx polling callback

 * @napi: napi info

 * @budget: limit of packets to clean

 */

static int atl1c_clean(struct napi_struct *napi, int budget)

{

drivers/net/ethernet/atheros/atl1e/atl1e_main.c

+5 −2
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ static inline void atl1e_irq_reset(struct atl1e_adapter *adapter) 


/**

 * atl1e_phy_config - Timer Call-back

 * @data: pointer to netdev cast into an unsigned long

 * @t: timer list containing pointer to netdev cast into an unsigned long

 */

static void atl1e_phy_config(struct timer_list *t)

{
@@ -196,7 +196,7 @@ static int atl1e_check_link(struct atl1e_adapter *adapter) 


/**

 * atl1e_link_chg_task - deal with link change event Out of interrupt context

 * @netdev: network interface device structure

 * @work: work struct with driver info

 */

static void atl1e_link_chg_task(struct work_struct *work)

{
@@ -246,6 +246,7 @@ static void atl1e_cancel_work(struct atl1e_adapter *adapter) 
/**

 * atl1e_tx_timeout - Respond to a Tx Hang

 * @netdev: network interface device structure

 * @txqueue: the index of the hanging queue

 */

static void atl1e_tx_timeout(struct net_device *netdev, unsigned int txqueue)

{
@@ -1502,6 +1503,8 @@ static void atl1e_clean_rx_irq(struct atl1e_adapter *adapter, u8 que, 


/**

 * atl1e_clean - NAPI Rx polling callback

 * @napi: napi info

 * @budget: number of packets to clean

 */

static int atl1e_clean(struct napi_struct *napi, int budget)

{