Commit e662c16f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

usb: early: xhci-dbc: Optimize early_xdbc_write() 



There is no point in zeroing 'buf'.
It would be cleared only once, and if the 'while' loop is executed several
times, all but the first run would have a 'dirty' buffer.
Moreover, the size of the chunk is computed in the loop and this size is
passed to xdbc_bulk_write().

So remove this useless memset().

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/687bbcd940c59fbddd0e3a8b578fd3422962e50f.1675016180.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4a97ab3

drivers/usb/early/xhci-dbc.c

+1 −1
Original line number Diff line number Diff line
@@ -881,7 +881,7 @@ static void early_xdbc_write(struct console *con, const char *str, u32 n) 


	if (!xdbc.xdbc_reg)

		return;

	memset(buf, 0, XDBC_MAX_PACKET);



	while (n > 0) {

		for (chunk = 0; chunk < XDBC_MAX_PACKET && n > 0; str++, chunk++, n--) {