Commit e5f32bf0 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper 



Since pm.h provides a helper for system no-IRQ PM callbacks,
switch the driver to use it instead of open coded variant.

Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230717172821.62827-4-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 2a6c0b47

drivers/pinctrl/intel/pinctrl-cherryview.c

+3 −7
Original line number Diff line number Diff line
@@ -1741,7 +1741,6 @@ static int chv_pinctrl_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int chv_pinctrl_suspend_noirq(struct device *dev)

{

	struct intel_pinctrl *pctrl = dev_get_drvdata(dev);
@@ -1825,12 +1824,9 @@ static int chv_pinctrl_resume_noirq(struct device *dev) 


	return 0;

}

#endif



static const struct dev_pm_ops chv_pinctrl_pm_ops = {

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(chv_pinctrl_suspend_noirq,

				      chv_pinctrl_resume_noirq)

};

static DEFINE_NOIRQ_DEV_PM_OPS(chv_pinctrl_pm_ops,

			       chv_pinctrl_suspend_noirq, chv_pinctrl_resume_noirq);



static const struct acpi_device_id chv_pinctrl_acpi_match[] = {

	{ "INT33FF", (kernel_ulong_t)chv_soc_data },
@@ -1843,7 +1839,7 @@ static struct platform_driver chv_pinctrl_driver = { 
	.remove = chv_pinctrl_remove,

	.driver = {

		.name = "cherryview-pinctrl",

		.pm = &chv_pinctrl_pm_ops,

		.pm = pm_sleep_ptr(&chv_pinctrl_pm_ops),

		.acpi_match_table = chv_pinctrl_acpi_match,

	},

};