Commit e5c89479 authored by Mario Limonciello's avatar Mario Limonciello Committed by Damien Le Moal
Browse files

ata: ahci: Rename `AHCI_HFLAG_IS_MOBILE` 



`AHCI_HFLAG_IS_MOBILE` designates that a chipset should be using the
default link power management policy from a kernel configuration item.

As desktop chipsets may also be interested in this default policy
configuration, rename the flag to `AHCI_HFLAG_USE_LPM_POLICY` to more
accurately reflect that a chipset doesn't have to be mobile to adopt it.

Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 099849af

drivers/ata/ahci.c

+3 −3
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static const struct ata_port_info ahci_port_info[] = { 
		.port_ops	= &ahci_ops,

	},

	[board_ahci_low_power] = {

		AHCI_HFLAGS	(AHCI_HFLAG_IS_MOBILE),

		AHCI_HFLAGS	(AHCI_HFLAG_USE_LPM_POLICY),

		.flags		= AHCI_FLAG_COMMON,

		.pio_mask	= ATA_PIO4,

		.udma_mask	= ATA_UDMA6,
@@ -1598,8 +1598,8 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap, 
	int policy = CONFIG_SATA_MOBILE_LPM_POLICY;





	/* Ignore processing for non mobile platforms */

	if (!(hpriv->flags & AHCI_HFLAG_IS_MOBILE))

	/* Ignore processing for chipsets that don't use policy */

	if (!(hpriv->flags & AHCI_HFLAG_USE_LPM_POLICY))

		return;



	/* user modified policy via module param */

drivers/ata/ahci.h

+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ enum { 
	AHCI_HFLAG_YES_ALPM		= (1 << 23), /* force ALPM cap on */

	AHCI_HFLAG_NO_WRITE_TO_RO	= (1 << 24), /* don't write to read

							only registers */

	AHCI_HFLAG_IS_MOBILE		= (1 << 25), /* mobile chipset, use

	AHCI_HFLAG_USE_LPM_POLICY	= (1 << 25), /* chipset that should use

							SATA_MOBILE_LPM_POLICY

							as default lpm_policy */

	AHCI_HFLAG_SUSPEND_PHYS		= (1 << 26), /* handle PHYs during