Commit e5bc0e1d authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: vicodec: move v4l2_ctrl_request_complete after spin_unlock 



v4l2_ctrl_request_complete can sleep, so can't be called while
a spinlock is held.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 22670e77

drivers/media/platform/vicodec/vicodec-core.c

+2 −2
Original line number Diff line number Diff line
@@ -442,14 +442,14 @@ static void device_run(void *priv) 
		ctx->comp_has_next_frame = false;

	}

	v4l2_m2m_buf_done(dst_buf, state);

	if (ctx->is_stateless && src_req)

		v4l2_ctrl_request_complete(src_req, &ctx->hdl);



	ctx->comp_size = 0;

	ctx->header_size = 0;

	ctx->comp_magic_cnt = 0;

	ctx->comp_has_frame = false;

	spin_unlock(ctx->lock);

	if (ctx->is_stateless && src_req)

		v4l2_ctrl_request_complete(src_req, &ctx->hdl);



	if (ctx->is_enc)

		v4l2_m2m_job_finish(dev->stateful_enc.m2m_dev, ctx->fh.m2m_ctx);