Commit e5b91349 authored May 21, 2020 by Dinghao Liu Committed by Felipe Balbi May 25, 2020

usb: cdns3: Fix runtime PM imbalance on error



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent eafa8004

drivers/usb/cdns3/cdns3-ti.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ static int cdns_ti_probe(struct platform_device *pdev)
		error = pm_runtime_get_sync(dev);
		if (error < 0) {
		dev_err(dev, "pm_runtime_get_sync failed: %d\n", error);
		goto err_get;
		goto err;
		}

		/* assert RESET */
		@@ -185,7 +185,6 @@ static int cdns_ti_probe(struct platform_device *pdev)

		err:
		pm_runtime_put_sync(data->dev);
		err_get:
		pm_runtime_disable(data->dev);

		return error;