Commit e590e46b authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf script: Remove some large stack allocations 



Some char buffers are stack allocated but in total they come to
24kb. Avoid Wstack-usage warnings by moving the arrays to being
dynamically allocated.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230527034324.2597593-3-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 232418a0

tools/perf/builtin-script.c

+13 −4
Original line number Diff line number Diff line
@@ -3318,14 +3318,21 @@ static int list_available_scripts(const struct option *opt __maybe_unused, 
				  int unset __maybe_unused)

{

	struct dirent *script_dirent, *lang_dirent;

	char scripts_path[MAXPATHLEN];

	char *buf, *scripts_path, *script_path, *lang_path, *first_half;

	DIR *scripts_dir, *lang_dir;

	char script_path[MAXPATHLEN];

	char lang_path[MAXPATHLEN];

	struct script_desc *desc;

	char first_half[BUFSIZ];

	char *script_root;



	buf = malloc(3 * MAXPATHLEN + BUFSIZ);

	if (!buf) {

		pr_err("malloc failed\n");

		exit(-1);

	}

	scripts_path = buf;

	script_path = buf + MAXPATHLEN;

	lang_path = buf + 2 * MAXPATHLEN;

	first_half = buf + 3 * MAXPATHLEN;



	snprintf(scripts_path, MAXPATHLEN, "%s/scripts", get_argv_exec_path());



	scripts_dir = opendir(scripts_path);
@@ -3334,6 +3341,7 @@ static int list_available_scripts(const struct option *opt __maybe_unused, 
			"open(%s) failed.\n"

			"Check \"PERF_EXEC_PATH\" env to set scripts dir.\n",

			scripts_path);

		free(buf);

		exit(-1);

	}
@@ -3364,6 +3372,7 @@ static int list_available_scripts(const struct option *opt __maybe_unused, 
			desc->half_liner ? desc->half_liner : "");

	}



	free(buf);

	exit(0);

}