Unverified Commit e589f9b7 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Konstantin Komarov
Browse files

fs/ntfs3: Fix some memory leaks in an error handling path of 'log_replay()' 



All error handling paths lead to 'out' where many resources are freed.

Do it as well here instead of a direct return, otherwise 'log', 'ra' and
'log->one_page_buf' (at least) will leak.

Fixes: b46acd6a ("fs/ntfs3: Add NTFS journal")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 8bb7eca9

fs/ntfs3/fslog.c

+4 −2
Original line number Diff line number Diff line
@@ -4085,8 +4085,10 @@ int log_replay(struct ntfs_inode *ni, bool *initialized) 
		if (client == LFS_NO_CLIENT_LE) {

			/* Insert "NTFS" client LogFile. */

			client = ra->client_idx[0];

			if (client == LFS_NO_CLIENT_LE)

				return -EINVAL;

			if (client == LFS_NO_CLIENT_LE) {

				err = -EINVAL;

				goto out;

			}



			t16 = le16_to_cpu(client);

			cr = ca + t16;