Commit e5827a00 authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: shut up -Wuninitialized in xfsaild_push 



-Wuninitialized complains about @target in xfsaild_push being
uninitialized in the case where the waitqueue is active but there is no
last item in the AIL to wait for.  I /think/ it should never be the case
that the subsequent xfs_trans_ail_cursor_first returns a log item and
hence we'll never end up at XFS_LSN_CMP, but let's make this explicit.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
parent fd5beaff

fs/xfs/xfs_trans_ail.c

+3 −1
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ xfsaild_push( 
	struct xfs_ail_cursor	cur;

	struct xfs_log_item	*lip;

	xfs_lsn_t		lsn;

	xfs_lsn_t		target;

	xfs_lsn_t		target = NULLCOMMITLSN;

	long			tout;

	int			stuck = 0;

	int			flushing = 0;
@@ -472,6 +472,8 @@ xfsaild_push( 


	XFS_STATS_INC(mp, xs_push_ail);



	ASSERT(target != NULLCOMMITLSN);



	lsn = lip->li_lsn;

	while ((XFS_LSN_CMP(lip->li_lsn, target) <= 0)) {

		int	lock_result;