Commit e57a1540 authored Feb 25, 2022 by Russell King (Oracle) Committed by David S. Miller Feb 26, 2022

net: dsa: ocelot: remove interface checks



When the supported interfaces bitmap is populated, phylink will itself
check that the interface mode is present in this bitmap. Drivers no
longer need to perform this check themselves. Remove these checks.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 79fda660

drivers/net/dsa/ocelot/felix_vsc9959.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -944,15 +944,8 @@ static void vsc9959_phylink_validate(struct ocelot *ocelot, int port,
		unsigned long *supported,
		struct phylink_link_state *state)
		{
		struct ocelot_port *ocelot_port = ocelot->ports[port];
		__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };

		if (state->interface != PHY_INTERFACE_MODE_NA &&
		state->interface != ocelot_port->phy_mode) {
		linkmode_zero(supported);
		return;
		}

		phylink_set_port_modes(mask);
		phylink_set(mask, Autoneg);
		phylink_set(mask, Pause);

drivers/net/dsa/ocelot/seville_vsc9953.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -917,15 +917,8 @@ static void vsc9953_phylink_validate(struct ocelot *ocelot, int port,
		unsigned long *supported,
		struct phylink_link_state *state)
		{
		struct ocelot_port *ocelot_port = ocelot->ports[port];
		__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };

		if (state->interface != PHY_INTERFACE_MODE_NA &&
		state->interface != ocelot_port->phy_mode) {
		linkmode_zero(supported);
		return;
		}

		phylink_set_port_modes(mask);
		phylink_set(mask, Autoneg);
		phylink_set(mask, Pause);