Commit e566b311 authored by Zhihao Cheng's avatar Zhihao Cheng Committed by Wen Zhiwei
Browse files

Revert "ubifs: ubifs_symlink: Fix memleak of inode->i_link in error path" 

stable inclusion
from stable-v6.6.55
commit 3faea7810e2b3e9a9a92ef42d7e5feaeb8ff7133
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB0MX4

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3faea7810e2b3e9a9a92ef42d7e5feaeb8ff7133



--------------------------------

commit 7bed61a1cf166b5c113047fc8f60ff22dcb04893 upstream.

This reverts commit 6379b44cdcd67f5f5d986b73953e99700591edfa. Commit
1e022216dcd2 ("ubifs: ubifs_symlink: Fix memleak of inode->i_link in
error path") is applied again in commit 6379b44cdcd6 ("ubifs:
ubifs_symlink: Fix memleak of inode->i_link in error path"), which
changed ubifs_mknod (It won't become a real problem). Just revert it.

Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent 56ad4e93

fs/ubifs/dir.c

+0 −2
Original line number Diff line number Diff line
@@ -1128,8 +1128,6 @@ static int ubifs_mknod(struct mnt_idmap *idmap, struct inode *dir, 
	dir_ui->ui_size = dir->i_size;

	mutex_unlock(&dir_ui->ui_mutex);

out_inode:

	/* Free inode->i_link before inode is marked as bad. */

	fscrypt_free_inode(inode);

	make_bad_inode(inode);

	iput(inode);

out_fname: