Commit e5434688 authored by Shai Malin's avatar Shai Malin Committed by David S. Miller
Browse files

qede: Fix memset corruption 



Thanks to Kees Cook who detected the problem of memset that starting
from not the first member, but sized for the whole struct.
The better change will be to remove the redundant memset and to clear
only the msix_cnt member.

Signed-off-by: default avatarPrabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: default avatarAriel Elior <aelior@marvell.com>
Signed-off-by: default avatarShai Malin <smalin@marvell.com>
Reported-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b9fff64

drivers/net/ethernet/qlogic/qede/qede_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1874,6 +1874,7 @@ static void qede_sync_free_irqs(struct qede_dev *edev) 
	}



	edev->int_info.used_cnt = 0;

	edev->int_info.msix_cnt = 0;

}



static int qede_req_msix_irqs(struct qede_dev *edev)
@@ -2427,7 +2428,6 @@ static int qede_load(struct qede_dev *edev, enum qede_load_mode mode, 
	goto out;

err4:

	qede_sync_free_irqs(edev);

	memset(&edev->int_info.msix_cnt, 0, sizeof(struct qed_int_info));

err3:

	qede_napi_disable_remove(edev);

err2: