Commit e51e5a74 authored by Qi Tao's avatar Qi Tao Committed by JangShui Yang
Browse files

crypto: hisilicon/sec2 - fix some cleanup issues 

maillist inclusion
category: cleanup
bugzilla: https://gitee.com/openeuler/kernel/issues/I925L9
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev.git/commit/?id=dd1a502cabcaa410c68ee9f74eae50d85e89fee3



----------------------------------------------------------------------

This patch fixes following cleanup issues:
 - The return value of the function is
   inconsistent with the actual return type.
 - After the pointer type is directly converted
   to the `__le64` type, the program may crash
   or produce unexpected results.

Signed-off-by: default avatarQi Tao <taoqi10@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarJangShui Yang <yangjiangshui@h-partners.com>
parent 2caf3680

drivers/crypto/hisilicon/sec2/sec_crypto.c

+2 −2
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ struct sec_aead { 
};



/* Get an en/de-cipher queue cyclically to balance load over queues of TFM */

static inline int sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req)

static inline u32 sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req)

{

	if (req->c_req.encrypt)

		return (u32)atomic_inc_return(&ctx->enc_qcyclic) %
@@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req) 
	sec_sqe3->bd_param = cpu_to_le32(bd_param);



	sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);

	sec_sqe3->tag = cpu_to_le64(req);

	sec_sqe3->tag = cpu_to_le64((unsigned long)req);



	return 0;

}