Commit e514f1fd authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

ARM: omap: fix missing declaration warnings 



Moving the plat-omap files triggered a sparse warning for omap1 and
omap2 that is now in a different file from before. Found some more sparse
warnings here that I address by making sure the declaration is visible
to both the caller and the callee, or they are static

mach-omap1/fb.c:33:17: warning: symbol 'omap_fb_resources' was not declared. Should it be static?
mach-omap1/timer32k.c:215:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static?
mach-omap1/i2c.c:36:12: warning: symbol 'omap_i2c_add_bus' was not declared. Should it be static?
mach-omap1/i2c.c:115:12: warning: symbol 'omap_register_i2c_bus_cmdline' was not declared. Should it be static?
mach-omap1/i2c.c:140:12: warning: symbol 'omap_register_i2c_bus' was not declared. Should it be static?
mach-omap2/dma.c:180:34: warning: symbol 'dma_plat_info' was not declared. Should it be static?
mach-omap2/omap4-common.c:116:6: warning: symbol 'omap_interconnect_sync' was not declared. Should it be static?
mach-omap2/omap-iommu.c:113:5: warning: symbol 'omap_iommu_set_pwrdm_constraint' was not declared. Should it be static?

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reviewed-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent deb44711

arch/arm/mach-omap1/fb.c

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ static struct omapfb_platform_data omapfb_config; 


static u64 omap_fb_dma_mask = ~(u32)0;



struct resource omap_fb_resources[] = {

static struct resource omap_fb_resources[] = {

	{

		.name  = "irq",

		.start = INT_LCD_CTRL,

arch/arm/mach-omap1/i2c.c

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ 


#include "mux.h"

#include "soc.h"

#include "i2c.h"



#define OMAP_I2C_SIZE		0x3f

#define OMAP1_I2C_BASE		0xfffb3800

arch/arm/mach-omap1/timer32k.c

+1 −1
Original line number Diff line number Diff line
@@ -212,7 +212,7 @@ static void omap_read_persistent_clock64(struct timespec64 *ts) 
 * Returns 0 upon success or negative error code upon failure.

 *

 */

int __init omap_init_clocksource_32k(void __iomem *vbase)

static int __init omap_init_clocksource_32k(void __iomem *vbase)

{

	int ret;

arch/arm/mach-omap2/common.h

+12 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ extern void omap4_sar_ram_init(void); 
extern void __iomem *omap4_get_sar_ram_base(void);

extern void omap4_mpuss_early_init(void);

extern void omap_do_wfi(void);



extern void omap_interconnect_sync(void);



#ifdef CONFIG_SMP

/* Needed for secondary core boot */
@@ -360,5 +360,16 @@ extern int omap_dss_reset(struct omap_hwmod *); 
/* SoC specific clock initializer */

int omap_clk_init(void);



#if IS_ENABLED(CONFIG_OMAP_IOMMU)

int omap_iommu_set_pwrdm_constraint(struct platform_device *pdev, bool request,

				    u8 *pwrst);

#else

static inline int omap_iommu_set_pwrdm_constraint(struct platform_device *pdev,

						  bool request, u8 *pwrst)

{

	return 0;

}

#endif



#endif /* __ASSEMBLER__ */

#endif /* __ARCH_ARM_MACH_OMAP2PLUS_COMMON_H */

arch/arm/mach-omap2/dma.c

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
#include <linux/omap-dma.h>



#include "soc.h"

#include "common.h"



static const struct omap_dma_reg reg_map[] = {

	[REVISION]	= { 0x0000, 0x00, OMAP_DMA_REG_32BIT },