Commit e4ea3cc6 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

tools: ynl-gen: get attr type outside of if() 



Reading attr type with mnl_attr_get_type() for each condition
leads to most conditions being longer than 80 chars.
Avoid this by reading the type to a variable on the stack.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c0f1466

tools/net/ynl/ynl-gen-c.py

+3 −1
Original line number Diff line number Diff line
@@ -153,7 +153,7 @@ class Type(SpecAttr): 
            init_lines = [init_lines]



        kw = 'if' if first else 'else if'

        ri.cw.block_start(line=f"{kw} (mnl_attr_get_type(attr) == {self.enum_name})")

        ri.cw.block_start(line=f"{kw} (type == {self.enum_name})")

        if local_vars:

            for local in local_vars:

                ri.cw.p(local)
@@ -1418,6 +1418,8 @@ def _multi_parse(ri, struct, init_lines, local_vars): 


    ri.cw.nl()

    ri.cw.block_start(line=iter_line)

    ri.cw.p('unsigned int type = mnl_attr_get_type(attr);')

    ri.cw.nl()



    first = True

    for _, arg in struct.member_list():