Commit e4cf19ff authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: thingm: set the proper error code before leaving 



In case of an unsupported firmware, the driver bails out without setting
the LEDs interfaces, but forget to set the proper error code.
err is then still equal to 0 and the hid subsytem consider the device
to be in perfect shape.
When removing it, thingm_remove() tries to unbind the rgb LEDs which
has not been created, leading to a segfault.

Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 844817e4

drivers/hid/hid-thingm.c

+1 −0
Original line number Diff line number Diff line
@@ -250,6 +250,7 @@ static int thingm_probe(struct hid_device *hdev, const struct hid_device_id *id) 


	if (!tdev->fwinfo) {

		hid_err(hdev, "unsupported firmware %c\n", tdev->version.major);

		err = -ENODEV;

		goto stop;

	}