Commit e4cc6465 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: remove BIO_PAGE_REFFED 



Now that all block direct I/O helpers use page pinning, this flag is
unused.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDavid Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20230614140341.521331-4-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2e82f6c3

block/blk.h

+0 −2
Original line number Diff line number Diff line
@@ -445,8 +445,6 @@ static inline void bio_release_page(struct bio *bio, struct page *page) 
{

	if (bio_flagged(bio, BIO_PAGE_PINNED))

		unpin_user_page(page);

	else if (bio_flagged(bio, BIO_PAGE_REFFED))

		put_page(page);

}



struct request_queue *blk_alloc_queue(int node_id);

include/linux/bio.h

+1 −2
Original line number Diff line number Diff line
@@ -492,8 +492,7 @@ void zero_fill_bio(struct bio *bio); 


static inline void bio_release_pages(struct bio *bio, bool mark_dirty)

{

	if (bio_flagged(bio, BIO_PAGE_REFFED) ||

	    bio_flagged(bio, BIO_PAGE_PINNED))

	if (bio_flagged(bio, BIO_PAGE_PINNED))

		__bio_release_pages(bio, mark_dirty);

}

include/linux/blk_types.h

+0 −1
Original line number Diff line number Diff line
@@ -326,7 +326,6 @@ struct bio { 
 */

enum {

	BIO_PAGE_PINNED,	/* Unpin pages in bio_release_pages() */

	BIO_PAGE_REFFED,	/* put pages in bio_release_pages() */

	BIO_CLONED,		/* doesn't own data */

	BIO_BOUNCED,		/* bio is a bounce bio */

	BIO_QUIET,		/* Make BIO Quiet */