Commit e4b8700e authored by Pavel Skripkin's avatar Pavel Skripkin Committed by David S. Miller
Browse files

net: ethernet: ezchip: fix UAF in nps_enet_remove



priv is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing priv
pointer. So, fix it by moving free_netdev() after netif_napi_del()
call.

Fixes: 0dd07709 ("NET: Add ezchip ethernet driver")
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e3a5de6d
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -642,8 +642,8 @@ static s32 nps_enet_remove(struct platform_device *pdev)
	struct nps_enet_priv *priv = netdev_priv(ndev);

	unregister_netdev(ndev);
	free_netdev(ndev);
	netif_napi_del(&priv->napi);
	free_netdev(ndev);

	return 0;
}