Commit e4b1045b authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski
Browse files

ionic: fix missing pci_release_regions() on error in ionic_probe() 



If ionic_map_bars() fails, pci_release_regions() need be called.

Fixes: fbfb8031 ("ionic: Add hardware init and device commands")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220506034040.2614129-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent edae34a3

drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c

+2 −1
Original line number Diff line number Diff line
@@ -256,7 +256,7 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	err = ionic_map_bars(ionic);

	if (err)

		goto err_out_pci_disable_device;

		goto err_out_pci_release_regions;



	/* Configure the device */

	err = ionic_setup(ionic);
@@ -360,6 +360,7 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


err_out_unmap_bars:

	ionic_unmap_bars(ionic);

err_out_pci_release_regions:

	pci_release_regions(pdev);

err_out_pci_disable_device:

	pci_disable_device(pdev);