Commit e484fd73 authored by Amir Goldstein's avatar Amir Goldstein Committed by Christian Brauner
Browse files

io_uring: use kiocb_{start,end}_write() helpers 



Use helpers instead of the open coded dance to silence lockdep warnings.

Suggested-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Message-Id: <20230817141337.1025891-5-amir73il@gmail.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ed0360bb

io_uring/rw.c

+4 −19
Original line number Diff line number Diff line
@@ -222,15 +222,10 @@ static bool io_rw_should_reissue(struct io_kiocb *req) 


static void io_req_end_write(struct io_kiocb *req)

{

	/*

	 * Tell lockdep we inherited freeze protection from submission

	 * thread.

	 */

	if (req->flags & REQ_F_ISREG) {

		struct super_block *sb = file_inode(req->file)->i_sb;

		struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw);



		__sb_writers_acquired(sb, SB_FREEZE_WRITE);

		sb_end_write(sb);

		kiocb_end_write(&rw->kiocb);

	}

}
@@ -902,18 +897,8 @@ int io_write(struct io_kiocb *req, unsigned int issue_flags) 
		return ret;

	}



	/*

	 * Open-code file_start_write here to grab freeze protection,

	 * which will be released by another thread in

	 * io_complete_rw().  Fool lockdep by telling it the lock got

	 * released so that it doesn't complain about the held lock when

	 * we return to userspace.

	 */

	if (req->flags & REQ_F_ISREG) {

		sb_start_write(file_inode(req->file)->i_sb);

		__sb_writers_release(file_inode(req->file)->i_sb,

					SB_FREEZE_WRITE);

	}

	if (req->flags & REQ_F_ISREG)

		kiocb_start_write(kiocb);

	kiocb->ki_flags |= IOCB_WRITE;



	if (likely(req->file->f_op->write_iter))