Commit e47a0ced authored by Len Baker's avatar Len Baker Committed by Wolfram Sang
Browse files

i2c: sun6i-pw2i: Prefer strscpy over strlcpy 

strlcpy() reads the entire source buffer first. This read may exceed the
destination size limit. This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated. The safe
replacement is strscpy().

This is a previous step in the path to remove the strlcpy() function
entirely from the kernel [1].

[1] https://github.com/KSPP/linux/issues/89



Signed-off-by: default avatarLen Baker <len.baker@gmx.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent e517992b

drivers/i2c/busses/i2c-sun6i-p2wi.c

+1 −1
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ static int p2wi_probe(struct platform_device *pdev) 
	if (IS_ERR(p2wi->regs))

		return PTR_ERR(p2wi->regs);



	strlcpy(p2wi->adapter.name, pdev->name, sizeof(p2wi->adapter.name));

	strscpy(p2wi->adapter.name, pdev->name, sizeof(p2wi->adapter.name));

	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;