Commit e471eedd authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Leon Romanovsky
Browse files

RDMA/rtrs-clt: Use the bitmap API to allocate bitmaps 

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Link: https://lore.kernel.org/r/ca9c5c8301d76d60de34640568b3db0d4401d050.1657298747.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent b577ea54

drivers/infiniband/ulp/rtrs/rtrs-clt.c

+3 −4
Original line number Diff line number Diff line
@@ -1403,8 +1403,7 @@ static int alloc_permits(struct rtrs_clt_sess *clt) 
	unsigned int chunk_bits;

	int err, i;



	clt->permits_map = kcalloc(BITS_TO_LONGS(clt->queue_depth),

				   sizeof(long), GFP_KERNEL);

	clt->permits_map = bitmap_zalloc(clt->queue_depth, GFP_KERNEL);

	if (!clt->permits_map) {

		err = -ENOMEM;

		goto out_err;
@@ -1426,7 +1425,7 @@ static int alloc_permits(struct rtrs_clt_sess *clt) 
	return 0;



err_map:

	kfree(clt->permits_map);

	bitmap_free(clt->permits_map);

	clt->permits_map = NULL;

out_err:

	return err;
@@ -1440,7 +1439,7 @@ static void free_permits(struct rtrs_clt_sess *clt) 
		wait_event(clt->permits_wait,

			   find_first_bit(clt->permits_map, sz) >= sz);

	}

	kfree(clt->permits_map);

	bitmap_free(clt->permits_map);

	clt->permits_map = NULL;

	kfree(clt->permits);

	clt->permits = NULL;