Commit e46e06ff authored by Yuanjun Gong's avatar Yuanjun Gong Committed by Paolo Abeni
Browse files

tipc: check return value of pskb_trim() 



goto free_skb if an unexpected result is returned by pskb_tirm()
in tipc_crypto_rcv_complete().

Fixes: fc1b6d6d ("tipc: introduce TIPC encryption & authentication")
Signed-off-by: default avatarYuanjun Gong <ruc_gongyuanjun@163.com>
Reviewed-by: default avatarTung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/20230725064810.5820-1-ruc_gongyuanjun@163.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 5c85f706

net/tipc/crypto.c

+2 −1
Original line number Diff line number Diff line
@@ -1960,7 +1960,8 @@ static void tipc_crypto_rcv_complete(struct net *net, struct tipc_aead *aead, 


	skb_reset_network_header(*skb);

	skb_pull(*skb, tipc_ehdr_size(ehdr));

	pskb_trim(*skb, (*skb)->len - aead->authsize);

	if (pskb_trim(*skb, (*skb)->len - aead->authsize))

		goto free_skb;



	/* Validate TIPCv2 message */

	if (unlikely(!tipc_msg_validate(skb))) {