Commit e463786f authored by Dario Binacchi's avatar Dario Binacchi Committed by Alexandre Belloni
Browse files

rtc: omap: use rtc_write to access OMAP_RTC_OSC_REG 



The RTC_OSC_REG register is 32-bit, but the useful information is found
in the 7 least significant bits (bits 7-31 are reserved). And in fact,
as you can see from the code, all read accesses are 8-bit, as well as
some writes. Let's make sure all writes are 8-bit. Moreover, in contexts
where consecutive reads / writes after the busy check must take place
within 15 us, it is better not to waste time on useless accesses.

Signed-off-by: default avatarDario Binacchi <dariobin@libero.it>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210425145924.23353-1-dariobin@libero.it
parent fefbec3a

drivers/rtc/rtc-omap.c

+2 −3
Original line number Diff line number Diff line
@@ -786,8 +786,7 @@ static int omap_rtc_probe(struct platform_device *pdev) 
	/* enable RTC functional clock */

	if (rtc->type->has_32kclk_en) {

		reg = rtc_read(rtc, OMAP_RTC_OSC_REG);

		rtc_writel(rtc, OMAP_RTC_OSC_REG,

				reg | OMAP_RTC_OSC_32KCLK_EN);

		rtc_write(rtc, OMAP_RTC_OSC_REG, reg | OMAP_RTC_OSC_32KCLK_EN);

	}



	/* clear old status */
@@ -845,7 +844,7 @@ static int omap_rtc_probe(struct platform_device *pdev) 
		reg = rtc_read(rtc, OMAP_RTC_OSC_REG);

		reg &= ~OMAP_RTC_OSC_OSC32K_GZ_DISABLE;

		reg |= OMAP_RTC_OSC_32KCLK_EN | OMAP_RTC_OSC_SEL_32KCLK_SRC;

		rtc_writel(rtc, OMAP_RTC_OSC_REG, reg);

		rtc_write(rtc, OMAP_RTC_OSC_REG, reg);

	}



	rtc->type->lock(rtc);