Commit e4313be1 authored by Marek Behún's avatar Marek Behún Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Fix return value of MSI domain .alloc() method 

MSI domain callback .alloc() (implemented by advk_msi_irq_domain_alloc()
function) should return zero on success, since non-zero value indicates
failure.

When the driver was converted to generic MSI API in commit f21a8b1b
("PCI: aardvark: Move to MSI handling using generic MSI support"), it
was converted so that it returns hwirq number.

Fix this.

Link: https://lore.kernel.org/r/20211028185659.20329-3-kabel@kernel.org


Fixes: f21a8b1b ("PCI: aardvark: Move to MSI handling using generic MSI support")
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
parent 7a41ae80

drivers/pci/controller/pci-aardvark.c

+1 −1
Original line number Diff line number Diff line
@@ -1138,7 +1138,7 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain, 
				    domain->host_data, handle_simple_irq,

				    NULL, NULL);



	return hwirq;

	return 0;

}



static void advk_msi_irq_domain_free(struct irq_domain *domain,