Commit e40df9ef authored by Claudio Imbrenda's avatar Claudio Imbrenda Committed by Janosch Frank
Browse files

KVM: s390: pv: clear the state without memset 



Do not use memset to clean the whole struct kvm_s390_pv; instead,
explicitly clear the fields that need to be cleared.

Upcoming patches will introduce new fields in the struct kvm_s390_pv
that will not need to be cleared.

Signed-off-by: default avatarClaudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: default avatarJanosch Frank <frankja@linux.ibm.com>
Link: https://lore.kernel.org/r/20220628135619.32410-8-imbrenda@linux.ibm.com


Message-Id: <20220628135619.32410-8-imbrenda@linux.ibm.com>
Signed-off-by: default avatarJanosch Frank <frankja@linux.ibm.com>
parent 72b1daff

arch/s390/kvm/pv.c

+9 −1
Original line number Diff line number Diff line
@@ -17,6 +17,14 @@ 
#include <linux/sched/mm.h>

#include "kvm-s390.h"



static void kvm_s390_clear_pv_state(struct kvm *kvm)

{

	kvm->arch.pv.handle = 0;

	kvm->arch.pv.guest_len = 0;

	kvm->arch.pv.stor_base = 0;

	kvm->arch.pv.stor_var = NULL;

}



int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc)

{

	int cc;
@@ -111,7 +119,7 @@ static void kvm_s390_pv_dealloc_vm(struct kvm *kvm) 
	vfree(kvm->arch.pv.stor_var);

	free_pages(kvm->arch.pv.stor_base,

		   get_order(uv_info.guest_base_stor_len));

	memset(&kvm->arch.pv, 0, sizeof(kvm->arch.pv));

	kvm_s390_clear_pv_state(kvm);

}



static int kvm_s390_pv_alloc_vm(struct kvm *kvm)