Unverified Commit e40df428 authored by Christian Brauner's avatar Christian Brauner Committed by Christian Brauner (Microsoft)
Browse files

orangefs: fix mode handling 



In 4053d250 ("orangefs: rework posix acl handling when creating new
filesystem objects") we tried to precalculate the correct mode when
creating a new inode. However, this leads to regressions when creating new
filesystem objects.

Even if we precalculate the mode we still need to call __orangefs_setattr()
to perform additional checks and we also need to update the mode of
ACL_TYPE_ACCESS acls set on the inode. The patch referenced above regressed
that. Restore that part of the old behavior and remove the mode
precalculation as it doesn't get us anything anymore.

Fixes: 4053d250 ("orangefs: rework posix acl handling when creating new filesystem objects")
Reported-by: default avatarMike Marshall <hubcap@omnibond.com>
Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
parent 5b52aebe

fs/orangefs/inode.c

+10 −1
Original line number Diff line number Diff line
@@ -1131,7 +1131,7 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir, 
	orangefs_set_inode(inode, ref);

	inode->i_ino = hash;	/* needed for stat etc */



	error = __orangefs_inode_getattr(inode, mode, ORANGEFS_GETATTR_NEW);

	error = orangefs_inode_getattr(inode, ORANGEFS_GETATTR_NEW);

	if (error)

		goto out_iput;
@@ -1158,6 +1158,15 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir, 
	gossip_debug(GOSSIP_INODE_DEBUG,

		     "Initializing ACL's for inode %pU\n",

		     get_khandle_from_ino(inode));

	if (mode != inode->i_mode) {

		struct iattr iattr = {

			.ia_mode = mode,

			.ia_valid = ATTR_MODE,

		};

		inode->i_mode = mode;

		__orangefs_setattr(inode, &iattr);

		__posix_acl_chmod(&acl, GFP_KERNEL, inode->i_mode);

	}

	posix_acl_release(acl);

	posix_acl_release(default_acl);

	return inode;

fs/orangefs/orangefs-kernel.h

+0 −1
Original line number Diff line number Diff line
@@ -423,7 +423,6 @@ int orangefs_inode_setxattr(struct inode *inode, 
#define ORANGEFS_GETATTR_SIZE 2



int orangefs_inode_getattr(struct inode *, int);

int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags);



int orangefs_inode_check_changed(struct inode *inode);

fs/orangefs/orangefs-utils.c

+2 −8
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static int orangefs_inode_is_stale(struct inode *inode, 
	return 0;

}



int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags)

int orangefs_inode_getattr(struct inode *inode, int flags)

{

	struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);

	struct orangefs_kernel_op_s *new_op;
@@ -369,8 +369,7 @@ int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags) 


	/* special case: mark the root inode as sticky */

	inode->i_mode = type | (is_root_handle(inode) ? S_ISVTX : 0) |

	    orangefs_inode_perms(&new_op->downcall.resp.getattr.attributes) |

	    mode;

	    orangefs_inode_perms(&new_op->downcall.resp.getattr.attributes);



	orangefs_inode->getattr_time = jiffies +

	    orangefs_getattr_timeout_msecs*HZ/1000;
@@ -382,11 +381,6 @@ int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags) 
	return ret;

}



int orangefs_inode_getattr(struct inode *inode, int flags)

{

	return __orangefs_inode_getattr(inode, 0, flags);

}



int orangefs_inode_check_changed(struct inode *inode)

{

	struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);