Commit e4006bfe authored by Zhang Rui's avatar Zhang Rui Committed by Rafael J. Wysocki
Browse files

thermal: gov_step_wise: Adjust code logic to match comment 



For the algorithm of choosing the next target state in step_wise
governor, the code does the right thing but is implemented in a
way different from what the comment describes. And this hurts the code
readability.

As the logic in the comment is simpler, adjust the code logic to align
with the comment.

No functional change.

Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
[ rjw: Subject edit ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cead266c

drivers/thermal/gov_step_wise.c

+6 −14
Original line number Diff line number Diff line
@@ -53,25 +53,17 @@ static unsigned long get_target_state(struct thermal_instance *instance, 
		return next_target;

	}



	switch (trend) {

	case THERMAL_TREND_RAISING:

	if (throttle) {

		if (trend == THERMAL_TREND_RAISING)

			next_target = clamp((cur_state + 1), instance->lower, instance->upper);

		}

		break;

	case THERMAL_TREND_DROPPING:

		if (cur_state <= instance->lower) {

			if (!throttle)

				next_target = THERMAL_NO_TARGET;

	} else {

			if (!throttle) {

		if (trend == THERMAL_TREND_DROPPING) {

			if (cur_state <= instance->lower)

				next_target = THERMAL_NO_TARGET;

			else

				next_target = clamp((cur_state - 1), instance->lower, instance->upper);

		}

	}

		break;

	default:

		break;

	}



	return next_target;

}