Commit e3d13da7 authored by Hans de Goede's avatar Hans de Goede
Browse files

platform/x86: asus-wmi: Fix regression when probing for fan curve control 



The fan curve control patches introduced a regression for at least the
TUF FX506 and possibly other TUF series laptops that do not have support
for fan curve control.

As part of the probing process, asus_wmi_evaluate_method_buf is called
to get the factory default fan curve . The WMI management function
returns 0 on certain laptops to indicate lack of fan curve control
instead of ASUS_WMI_UNSUPPORTED_METHOD. This 0 is transformed to
-ENODATA which results in failure when probing.

Fixes: 0f0ac158 ("platform/x86: asus-wmi: Add support for custom fan curves")
Reported-and-tested-by: default avatarAbhijeet V <abhijeetviswa@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220205112840.33095-1-hdegoede@redhat.com
parent 868d7618

drivers/platform/x86/asus-wmi.c

+1 −1
Original line number Diff line number Diff line
@@ -2223,7 +2223,7 @@ static int fan_curve_check_present(struct asus_wmi *asus, bool *available, 


	err = fan_curve_get_factory_default(asus, fan_dev);

	if (err) {

		if (err == -ENODEV)

		if (err == -ENODEV || err == -ENODATA)

			return 0;

		return err;

	}