Commit e3c1d6c8 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: 74xx-mmio: Use bits instead of plain numbers for flags 



The initial code was misleading to use bitwise AND against plain number,
and the commit d3054ba1 ("gpio: 74xx-mmio: Check MMIO_74XX_DIR_IN flag
in mmio_74xx_dir_in()") missed that. Switch definitions to be defined bits
for the correct comparison.

Fixes: d3054ba1 ("gpio: 74xx-mmio: Check MMIO_74XX_DIR_IN flag in mmio_74xx_dir_in()")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent f2a2f2c9

drivers/gpio/gpio-74xx-mmio.c

+2 −2
Original line number Diff line number Diff line
@@ -13,8 +13,8 @@ 
#include <linux/platform_device.h>

#include <linux/property.h>



#define MMIO_74XX_DIR_IN	(0 << 8)

#define MMIO_74XX_DIR_OUT	(1 << 8)

#define MMIO_74XX_DIR_IN	BIT(8)

#define MMIO_74XX_DIR_OUT	BIT(9)

#define MMIO_74XX_BIT_CNT(x)	((x) & GENMASK(7, 0))



struct mmio_74xx_gpio_priv {