Commit e36db29c authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

wifi: rtw88: Fix Sparse warning for rtw8723d_hw_spec 



Sparse lists the following:

  CHECK   drivers/net/wireless/realtek/rtw88/rtw8723d.c
drivers/net/wireless/realtek/rtw88/rtw8723d.c:2704:22: warning: symbol 'rtw8723d_hw_spec' was not declared. Should it be static?

The warning arises because the external declaration for rtw8723d_hw_spec
occurs in rtw8723de.h, which is not included in rtw8723d.h. That line is
moved, and the now empty file rtw8723de.h is deleted.

Symbol 'rtw8723d_hw_spec' can be made constant.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220524153621.19027-4-Larry.Finger@lwfinger.net
parent f86fc57f

drivers/net/wireless/realtek/rtw88/rtw8723d.c

+1 −1
Original line number Diff line number Diff line
@@ -2701,7 +2701,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8723d[] = { 
	{0x953, BIT(1), RTW_REG_DOMAIN_MAC8},

};



struct rtw_chip_info rtw8723d_hw_spec = {

const struct rtw_chip_info rtw8723d_hw_spec = {

	.ops = &rtw8723d_ops,

	.id = RTW_CHIP_TYPE_8723D,

	.fw_name = "rtw88/rtw8723d_fw.bin",

drivers/net/wireless/realtek/rtw88/rtw8723d.h

+2 −0
Original line number Diff line number Diff line
@@ -72,6 +72,8 @@ struct rtw8723d_efuse { 
	struct rtw8723de_efuse e;

};



extern const struct rtw_chip_info rtw8723d_hw_spec;



/* phy status page0 */

#define GET_PHY_STAT_P0_PWDB(phy_stat)                                         \

	le32_get_bits(*((__le32 *)(phy_stat) + 0x00), GENMASK(15, 8))

drivers/net/wireless/realtek/rtw88/rtw8723de.c

+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
#include <linux/module.h>

#include <linux/pci.h>

#include "pci.h"

#include "rtw8723de.h"

#include "rtw8723d.h"



static const struct pci_device_id rtw_8723de_id_table[] = {

	{

drivers/net/wireless/realtek/rtw88/rtw8723de.h

deleted100644 → 0
+0 −10
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */

/* Copyright(c) 2018-2019  Realtek Corporation

 */



#ifndef __RTW_8723DE_H_

#define __RTW_8723DE_H_



extern struct rtw_chip_info rtw8723d_hw_spec;



#endif