Commit e35a7762 authored Jun 03, 2023 by Li Nan Committed by Jialin Zhang Jun 03, 2023

block/badblocks: fix badblocks loss when badblocks combine

hulk inclusion
category: bugfix
bugzilla: 188569, https://gitee.com/openeuler/kernel/issues/I6ZG5B


CVE: NA

--------------------------------

badblocks will loss if we set it as below:

  # echo 1 1 > bad_blocks
  # echo 3 1 > bad_blocks
  # echo 1 5 > bad_blocks
  # cat bad_blocks
    1 3

we will combine badblocks if there is an intersection between p[lo] and
p[hi] in badblocks_set(). The end of new badblocks is p[hi]'s end now. but
p[lo] may cross p[hi] and new end should be the larger of p[lo] and p[hi].
  lo: |------------------------|
  hi:		|--------|

Fixes: 9e0e252a ("badblocks: Add core badblock management code")
Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Hou Tao <houtao1@huawei.com>

parent f9a3eea0

block/badblocks.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -267,16 +267,14 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors,
		if (sectors == 0 && hi < bb->count) {
		/* we might be able to combine lo and hi */
		/* Note: 's' is at the end of 'lo' */
		sector_t a = BB_OFFSET(p[hi]);
		int lolen = BB_LEN(p[lo]);
		int hilen = BB_LEN(p[hi]);
		int newlen = lolen + hilen - (s - a);
		sector_t a = BB_OFFSET(p[lo]);
		int newlen = max(s, BB_OFFSET(p[hi]) + BB_LEN(p[hi])) - a;

		if (s >= a && newlen < BB_MAX_LEN) {
		if (s >= BB_OFFSET(p[hi]) && newlen < BB_MAX_LEN) {
		/* yes, we can combine them */
		int ack = BB_ACK(p[lo]) && BB_ACK(p[hi]);

		p[lo] = BB_MAKE(BB_OFFSET(p[lo]), newlen, ack);
		p[lo] = BB_MAKE(a, newlen, ack);
		memmove(p + hi, p + hi + 1,
		(bb->count - hi - 1) * 8);
		bb->count--;