Commit e3275a89 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

pinctrl: Relax user input size in pinmux_select() 



This is debugfs and there is no much sense to strict the user from
sending as much data as they can. The memdup_user_nul() will anyway
fail if there is not enough memory.

Relax the user input size by removing an artificial limitaion.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230604131215.78847-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 0d8675e1

drivers/pinctrl/pinmux.c

+0 −4
Original line number Diff line number Diff line
@@ -677,7 +677,6 @@ void pinmux_show_setting(struct seq_file *s, 
DEFINE_SHOW_ATTRIBUTE(pinmux_functions);

DEFINE_SHOW_ATTRIBUTE(pinmux_pins);



#define PINMUX_SELECT_MAX 128

static ssize_t pinmux_select(struct file *file, const char __user *user_buf,

				   size_t len, loff_t *ppos)

{
@@ -689,9 +688,6 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, 
	unsigned int num_groups;

	int fsel, gsel, ret;



	if (len > PINMUX_SELECT_MAX)

		return -ENOMEM;



	buf = memdup_user_nul(user_buf, len);

	if (IS_ERR(buf))

		return PTR_ERR(buf);