Commit e2e6a217 authored by Hui Tang's avatar Hui Tang Committed by Claudiu Beznea
Browse files

clk: microchip: check for null return of devm_kzalloc() 



Because of the possible failure of devm_kzalloc(), name might be NULL and
will cause null pointer dereference later.

Therefore, it might be better to check it and directly return -ENOMEM.

Fixes: d39fb172 ("clk: microchip: add PolarFire SoC fabric clock support")
Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
[claudiu.beznea: s/refrence/reference/, s/possilble/possible]
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20221119054858.178629-1-tanghui20@huawei.com
parent 57976762

drivers/clk/microchip/clk-mpfs-ccc.c

+6 −0
Original line number Diff line number Diff line
@@ -166,6 +166,9 @@ static int mpfs_ccc_register_outputs(struct device *dev, struct mpfs_ccc_out_hw_ 
		struct mpfs_ccc_out_hw_clock *out_hw = &out_hws[i];

		char *name = devm_kzalloc(dev, 23, GFP_KERNEL);



		if (!name)

			return -ENOMEM;



		snprintf(name, 23, "%s_out%u", parent->name, i);

		out_hw->divider.hw.init = CLK_HW_INIT_HW(name, &parent->hw, &clk_divider_ops, 0);

		out_hw->divider.reg = data->pll_base[i / MPFS_CCC_OUTPUTS_PER_PLL] +
@@ -200,6 +203,9 @@ static int mpfs_ccc_register_plls(struct device *dev, struct mpfs_ccc_pll_hw_clo 
		struct mpfs_ccc_pll_hw_clock *pll_hw = &pll_hws[i];

		char *name = devm_kzalloc(dev, 18, GFP_KERNEL);



		if (!name)

			return -ENOMEM;



		pll_hw->base = data->pll_base[i];

		snprintf(name, 18, "ccc%s_pll%u", strchrnul(dev->of_node->full_name, '@'), i);

		pll_hw->name = (const char *)name;