Commit e2a54350 authored by Michael Sit Wei Hong's avatar Michael Sit Wei Hong Committed by Jakub Kicinski
Browse files

net: phy: dp83867: Fix SGMII FIFO depth for non OF devices 



Current driver code will read device tree node information,
and set default values if there is no info provided.

This is not done in non-OF devices leading to SGMII fifo depths being
set to the smallest size.

This patch sets the value to the default value of the PHY as stated in the
PHY datasheet.

Fixes: 4dc08dcc ("net: phy: dp83867: introduce critical chip default init for non-of platform")
Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20221110054938.925347-1-michael.wei.hong.sit@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8eab9be5

drivers/net/phy/dp83867.c

+7 −0
Original line number Diff line number Diff line
@@ -682,6 +682,13 @@ static int dp83867_of_init(struct phy_device *phydev) 
	 */

	dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MIN / 2;



	/* For non-OF device, the RX and TX FIFO depths are taken from

	 * default value. So, we init RX & TX FIFO depths here

	 * so that it is configured correctly later in dp83867_config_init();

	 */

	dp83867->tx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB;

	dp83867->rx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB;



	return 0;

}

#endif /* CONFIG_OF_MDIO */