Commit e2a0b786 authored Jun 02, 2023 by Connor O'Brien Committed by Paul E. McKenney Jul 14, 2023

torture: Support randomized shuffling for proxy exec testing



Currently shuffling sets the same cpu affinities for all tasks,
which makes us less likely to hit paths involving migrating
blocked tasks onto a cpu where they can't run.

This patch adds an element of randomness to allow affinities of
different writer tasks to diverge.

This has helped uncover issues in testing with Proxy Execution

Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: kernel-team@android.com
Signed-off-by: Connor O'Brien <connoro@google.com>
Signed-off-by: John Stultz <jstultz@google.com>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 9cafe974

kernel/torture.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -54,6 +54,9 @@ module_param(verbose_sleep_frequency, int, 0444);
		static int verbose_sleep_duration = 1;
		module_param(verbose_sleep_duration, int, 0444);

		static int random_shuffle;
		module_param(random_shuffle, int, 0444);

		static char *torture_type;
		static int verbose;

		@@ -518,6 +521,7 @@ static void torture_shuffle_task_unregister_all(void)
		*/
		static void torture_shuffle_tasks(void)
		{
		DEFINE_TORTURE_RANDOM(rand);
		struct shuffle_task *stp;

		cpumask_setall(shuffle_tmp_mask);
		@@ -537,8 +541,10 @@ static void torture_shuffle_tasks(void)
		cpumask_clear_cpu(shuffle_idle_cpu, shuffle_tmp_mask);

		mutex_lock(&shuffle_task_mutex);
		list_for_each_entry(stp, &shuffle_task_list, st_l)
		list_for_each_entry(stp, &shuffle_task_list, st_l) {
		if (!random_shuffle \|\| torture_random(&rand) & 0x1)
		set_cpus_allowed_ptr(stp->st_t, shuffle_tmp_mask);
		}
		mutex_unlock(&shuffle_task_mutex);

		cpus_read_unlock();