Commit e2a05339 authored by Bob Pearson's avatar Bob Pearson Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Use the correct size of wqe when processing SRQ 

The memcpy() that copies a WQE from a SRQ the QP uses an incorrect size.
The size should have been the size of the rxe_send_wqe struct not the size
of a pointer to it. The result is that IO operations using a SRQ on the
responder side will fail.

Fixes: ec0fa244 ("RDMA/rxe: Fix over copying in get_srq_wqe")
Link: https://lore.kernel.org/r/20210729220039.18549-2-rpearsonhpe@gmail.com


Signed-off-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent db4657af

drivers/infiniband/sw/rxe/rxe_resp.c

+1 −1
Original line number Diff line number Diff line
@@ -318,7 +318,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp) 
		pr_warn("%s: invalid num_sge in SRQ entry\n", __func__);

		return RESPST_ERR_MALFORMED_WQE;

	}

	size = sizeof(wqe) + wqe->dma.num_sge*sizeof(struct rxe_sge);

	size = sizeof(*wqe) + wqe->dma.num_sge*sizeof(struct rxe_sge);

	memcpy(&qp->resp.srq_wqe, wqe, size);



	qp->resp.wqe = &qp->resp.srq_wqe.wqe;