Commit e294f78d authored Jun 28, 2021 by Namjae Jeon

ksmbd: allow PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO addition...

ksmbd: allow PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO addition information in smb2 set info security

"cifsd: Fix regression in smb2_get_info" patch cause that dacl doesn't
work. windows send smb2 set info security with PROTECTED_DACL_SECINFO to
control dacl. But previous patch doesn't allow it.
This patch add PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO
addtional information flags in check.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 8a893315

fs/ksmbd/smb2pdu.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -4888,8 +4888,10 @@ static int smb2_get_info_sec(struct ksmbd_work *work,
		int addition_info = le32_to_cpu(req->AdditionalInformation);
		int rc;

		if (addition_info & ~(OWNER_SECINFO \| GROUP_SECINFO \| DACL_SECINFO)) {
		ksmbd_debug(SMB, "Unsupported addition info: 0x%x)\n",
		if (addition_info & ~(OWNER_SECINFO \| GROUP_SECINFO \| DACL_SECINFO \|
		PROTECTED_DACL_SECINFO \|
		UNPROTECTED_DACL_SECINFO)) {
		pr_err("Unsupported addition info: 0x%x)\n",
		addition_info);

		pntsd->revision = cpu_to_le16(1);