Commit e275d49a authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: phy: dp83869: fix unsigned comparisons against less than zero values 



Currently the comparisons of u16 integers value and sopass_val with
less than zero for error checking is always false because the values
are unsigned. Fix this by making these variables int.  This does not
affect the shift and mask operations performed on these variables

Addresses-Coverity: ("Unsigned compared against zero")
Fixes: 49fc2301 ("net: phy: dp83869: support Wake on LAN")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarDan Murphy <dmurphy@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd6ebb6f

drivers/net/phy/dp83869.c

+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ static int dp83869_set_wol(struct phy_device *phydev, 
static void dp83869_get_wol(struct phy_device *phydev,

			    struct ethtool_wolinfo *wol)

{

	u16 value, sopass_val;

	int value, sopass_val;



	wol->supported = (WAKE_UCAST | WAKE_BCAST | WAKE_MAGIC |

			WAKE_MAGICSECURE);