Commit e2566e0b authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Remove a member variable 



Remove the 'response' member variable because no code reads its value.
Additionally, move the ufs_query_req and ufs_query_res data structure
definitions into include/ufs/ufshcd.h because these data structures are
related to the UFS host controller driver.

Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230727194457.3152309-11-bvanassche@acm.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f9c028e7

drivers/ufs/core/ufshcd.c

+1 −5
Original line number Diff line number Diff line
@@ -3014,12 +3014,8 @@ static int ufshcd_clear_cmd(struct ufs_hba *hba, u32 task_tag) 
static int

ufshcd_check_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)

{

	struct ufs_query_res *query_res = &hba->dev_cmd.query.response;



	/* Get the UPIU response */

	query_res->response = ufshcd_get_rsp_upiu_result(lrbp->ucd_rsp_ptr) >>

	return ufshcd_get_rsp_upiu_result(lrbp->ucd_rsp_ptr) >>

				UPIU_RSP_CODE_OFFSET;

	return query_res->response;

}



/**

include/ufs/ufs.h

+0 −20
Original line number Diff line number Diff line
@@ -537,26 +537,6 @@ struct utp_upiu_rsp { 
	};

};



/**

 * struct ufs_query_req - parameters for building a query request

 * @query_func: UPIU header query function

 * @upiu_req: the query request data

 */

struct ufs_query_req {

	u8 query_func;

	struct utp_upiu_query upiu_req;

};



/**

 * struct ufs_query_resp - UPIU QUERY

 * @response: device response code

 * @upiu_res: query response data

 */

struct ufs_query_res {

	u8 response;

	struct utp_upiu_query upiu_res;

};



/*

 * VCCQ & VCCQ2 current requirement when UFS device is in sleep state

 * and link is in Hibern8 state.

include/ufs/ufshcd.h

+19 −0
Original line number Diff line number Diff line
@@ -202,6 +202,25 @@ struct ufshcd_lrb { 
	bool req_abort_skip;

};



/**

 * struct ufs_query_req - parameters for building a query request

 * @query_func: UPIU header query function

 * @upiu_req: the query request data

 */

struct ufs_query_req {

	u8 query_func;

	struct utp_upiu_query upiu_req;

};



/**

 * struct ufs_query_resp - UPIU QUERY

 * @response: device response code

 * @upiu_res: query response data

 */

struct ufs_query_res {

	struct utp_upiu_query upiu_res;

};



/**

 * struct ufs_query - holds relevant data structures for query request

 * @request: request upiu and function