Commit e23e6100 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Wolfram Sang
Browse files

I2C: ali15x3: Do PCI error checks on own line 



Instead of if conditions with line splits, use the usual error handling
pattern with a separate variable to improve readability.

No functional changes intended.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent c8930ed0

drivers/i2c/busses/i2c-ali15x3.c

+6 −5
Original line number Diff line number Diff line
@@ -165,14 +165,15 @@ static int ali15x3_setup(struct pci_dev *ALI15X3_dev) 
	}



	if(force_addr) {

		int ret;



		dev_info(&ALI15X3_dev->dev, "forcing ISA address 0x%04X\n",

			ali15x3_smba);

		if (PCIBIOS_SUCCESSFUL != pci_write_config_word(ALI15X3_dev,

								SMBBA,

								ali15x3_smba))

		ret = pci_write_config_word(ALI15X3_dev, SMBBA, ali15x3_smba);

		if (ret != PCIBIOS_SUCCESSFUL)

			goto error;

		if (PCIBIOS_SUCCESSFUL != pci_read_config_word(ALI15X3_dev,

								SMBBA, &a))

		ret = pci_read_config_word(ALI15X3_dev, SMBBA, &a);

		if (ret != PCIBIOS_SUCCESSFUL)

			goto error;

		if ((a & ~(ALI15X3_SMB_IOSIZE - 1)) != ali15x3_smba) {

			/* make sure it works */