Commit e22dcbc9 authored by Yuan Can's avatar Yuan Can Committed by Paolo Abeni
Browse files

net: ethernet: mtk_wed: Fix missing of_node_put() in mtk_wed_wo_hardware_init() 



The np needs to be released through of_node_put() in the error handling
path of mtk_wed_wo_hardware_init().

Fixes: 79968444 ("net: ethernet: mtk_wed: introduce wed wo support")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221205034339.112163-1-yuancan@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ed883bec

drivers/net/ethernet/mediatek/mtk_wed_wo.c

+6 −3
Original line number Diff line number Diff line
@@ -408,8 +408,10 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo) 
		return -ENODEV;



	wo->mmio.regs = syscon_regmap_lookup_by_phandle(np, NULL);

	if (IS_ERR_OR_NULL(wo->mmio.regs))

		return PTR_ERR(wo->mmio.regs);

	if (IS_ERR(wo->mmio.regs)) {

		ret = PTR_ERR(wo->mmio.regs);

		goto error_put;

	}



	wo->mmio.irq = irq_of_parse_and_map(np, 0);

	wo->mmio.irq_mask = MTK_WED_WO_ALL_INT_MASK;
@@ -457,7 +459,8 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo) 


error:

	devm_free_irq(wo->hw->dev, wo->mmio.irq, wo);



error_put:

	of_node_put(np);

	return ret;

}