Commit e209519b authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Paolo Abeni
Browse files

net: phy: c45: use "supported_eee" instead of supported for access validation 



Make sure we use proper variable to validate access to potentially not
supported registers. Otherwise we will get false read/write errors.

Reported-by: default avatarkernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/oe-lkp/202302211644.c12d19de-yujie.liu@intel.com


Fixes: 022c3f87 ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c749e3f8

drivers/net/phy/phy-c45.c

+3 −3
Original line number Diff line number Diff line
@@ -674,7 +674,7 @@ int genphy_c45_write_eee_adv(struct phy_device *phydev, unsigned long *adv) 
{

	int val, changed;



	if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {

	if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {

		val = linkmode_to_mii_eee_cap1_t(adv);



		/* In eee_broken_modes are stored MDIO_AN_EEE_ADV specific raw
@@ -726,7 +726,7 @@ static int genphy_c45_read_eee_adv(struct phy_device *phydev, 
{

	int val;



	if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {

	if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {

		/* IEEE 802.3-2018 45.2.7.13 EEE advertisement 1

		 * (Register 7.60)

		 */
@@ -762,7 +762,7 @@ static int genphy_c45_read_eee_lpa(struct phy_device *phydev, 
{

	int val;



	if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {

	if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {

		/* IEEE 802.3-2018 45.2.7.14 EEE link partner ability 1

		 * (Register 7.61)

		 */