Commit e1f78ecd authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum: Remove unnecessary RCU read-side critical section 



Since commit 7d8e8f34 ("mlxsw: core: Increase scope of RCU read-side
critical section"), all Rx handlers are called from an RCU read-side
critical section.

Remove the unnecessary rcu_read_lock() / rcu_read_unlock().

Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ab6dc9f

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+1 −4
Original line number Diff line number Diff line
@@ -2225,15 +2225,12 @@ void mlxsw_sp_sample_receive(struct mlxsw_sp *mlxsw_sp, struct sk_buff *skb, 
		goto out;

	}



	rcu_read_lock();

	sample = rcu_dereference(mlxsw_sp_port->sample);

	if (!sample)

		goto out_unlock;

		goto out;

	md.trunc_size = sample->truncate ? sample->trunc_size : skb->len;

	md.in_ifindex = mlxsw_sp_port->dev->ifindex;

	psample_sample_packet(sample->psample_group, skb, sample->rate, &md);

out_unlock:

	rcu_read_unlock();

out:

	consume_skb(skb);

}