Commit e1f4ecab authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: remove explicit phylink_generic_validate() references 



Virtually all conventional network drivers are now converted to use
phylink_generic_validate() - only DSA drivers and fman_memac remain,
so lets remove the necessity for network drivers to explicitly set
this member, and default to phylink_generic_validate() when unset.
This is possible as .validate must currently be set.

Any remaining instances that have not been addressed by this patch can
be fixed up later.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/E1or0FZ-001tRa-DI@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7ea8104d

drivers/net/ethernet/altera/altera_tse_main.c

+0 −1
Original line number Diff line number Diff line
@@ -1095,7 +1095,6 @@ static struct phylink_pcs *alt_tse_select_pcs(struct phylink_config *config, 
}



static const struct phylink_mac_ops alt_tse_phylink_ops = {

	.validate = phylink_generic_validate,

	.mac_an_restart = alt_tse_mac_an_restart,

	.mac_config = alt_tse_mac_config,

	.mac_link_down = alt_tse_mac_link_down,

drivers/net/ethernet/atheros/ag71xx.c

+0 −1
Original line number Diff line number Diff line
@@ -1086,7 +1086,6 @@ static void ag71xx_mac_link_up(struct phylink_config *config, 
}



static const struct phylink_mac_ops ag71xx_phylink_mac_ops = {

	.validate = phylink_generic_validate,

	.mac_config = ag71xx_mac_config,

	.mac_link_down = ag71xx_mac_link_down,

	.mac_link_up = ag71xx_mac_link_up,

drivers/net/ethernet/cadence/macb_main.c

+0 −1
Original line number Diff line number Diff line
@@ -742,7 +742,6 @@ static struct phylink_pcs *macb_mac_select_pcs(struct phylink_config *config, 
}



static const struct phylink_mac_ops macb_phylink_ops = {

	.validate = phylink_generic_validate,

	.mac_select_pcs = macb_mac_select_pcs,

	.mac_config = macb_mac_config,

	.mac_link_down = macb_mac_link_down,

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

+0 −1
Original line number Diff line number Diff line
@@ -236,7 +236,6 @@ static void dpaa2_mac_link_down(struct phylink_config *config, 
}



static const struct phylink_mac_ops dpaa2_mac_phylink_ops = {

	.validate = phylink_generic_validate,

	.mac_select_pcs = dpaa2_mac_select_pcs,

	.mac_config = dpaa2_mac_config,

	.mac_link_up = dpaa2_mac_link_up,

drivers/net/ethernet/freescale/enetc/enetc_pf.c

+0 −1
Original line number Diff line number Diff line
@@ -1111,7 +1111,6 @@ static void enetc_pl_mac_link_down(struct phylink_config *config, 
}



static const struct phylink_mac_ops enetc_mac_phylink_ops = {

	.validate = phylink_generic_validate,

	.mac_select_pcs = enetc_pl_mac_select_pcs,

	.mac_config = enetc_pl_mac_config,

	.mac_link_up = enetc_pl_mac_link_up,