Commit e1ee8434 authored Aug 17, 2022 by Wesley Cheng Committed by Greg Kroah-Hartman Aug 31, 2022

usb: dwc3: gadget: Force sending delayed status during soft disconnect

If any function drivers request for a delayed status phase, this leads to a
SETUP transfer timeout error, since the function may take longer to process
the DATA stage. This eventually results in end transfer timeouts, as there
is a pending SETUP transaction.

In addition, allow the DWC3_EP_DELAY_STOP to be set for if there is a
delayed status requested. Ocasionally, a host may abort the current SETUP
transaction, by issuing a subsequent SETUP token. In those situations, it
would result in an endxfer timeout as well.

Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220817182359.13550-3-quic_wcheng@quicinc.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 359d5a85

drivers/usb/dwc3/gadget.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2501,6 +2501,9 @@ static int dwc3_gadget_soft_disconnect(struct dwc3 *dwc)
		if (dwc->ep0state != EP0_SETUP_PHASE) {
		int ret;

		if (dwc->delayed_status)
		dwc3_ep0_send_delayed_status(dwc);

		reinit_completion(&dwc->ep0_in_setup);

		spin_unlock_irqrestore(&dwc->lock, flags);
		@@ -3693,7 +3696,7 @@ void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force,
		* timeout. Delay issuing the End Transfer command until the Setup TRB is
		* prepared.
		*/
		if (dwc->ep0state != EP0_SETUP_PHASE && !dwc->delayed_status) {
		if (dwc->ep0state != EP0_SETUP_PHASE) {
		dep->flags \|= DWC3_EP_DELAY_STOP;
		return;
		}