Commit e1c90bbb authored by Daniel Starke's avatar Daniel Starke Committed by Greg Kroah-Hartman
Browse files

tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config 

The variable 'ret' is not used before assignment from gsm_activate_mux().
Still it gets initialized to zero at declaration.

Fix this as remarked in the link below by moving the declaration to the
first assignment.

Link: https://lore.kernel.org/all/b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org/



Signed-off-by: default avatarDaniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20230817093231.2317-3-daniel.starke@siemens.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 901de5ac

drivers/tty/n_gsm.c

+1 −2
Original line number Diff line number Diff line
@@ -3280,7 +3280,6 @@ static void gsm_copy_config_values(struct gsm_mux *gsm, 


static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)

{

	int ret = 0;

	int need_close = 0;

	int need_restart = 0;
@@ -3359,7 +3358,7 @@ static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) 
	 * and removing from the mux array

	 */

	if (gsm->dead) {

		ret = gsm_activate_mux(gsm);

		int ret = gsm_activate_mux(gsm);

		if (ret)

			return ret;

		if (gsm->initiator)