Commit e1488513 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

tty_audit: use kzalloc() in tty_audit_buf_alloc() 



tty_audit_buf_alloc() manually erases most of the entries after
kmalloc(). So use kzalloc() and remove the manual sets to zero.

That way, we are sure that we do not omit anything.

Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230621101611.10580-3-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 777e4568

drivers/tty/tty_audit.c

+4 −4
Original line number Diff line number Diff line
@@ -33,16 +33,16 @@ static struct tty_audit_buf *tty_audit_buf_alloc(void) 
{

	struct tty_audit_buf *buf;



	buf = kmalloc(sizeof(*buf), GFP_KERNEL);

	buf = kzalloc(sizeof(*buf), GFP_KERNEL);

	if (!buf)

		goto err;



	buf->data = kmalloc(N_TTY_BUF_SIZE, GFP_KERNEL);

	if (!buf->data)

		goto err_buf;



	mutex_init(&buf->mutex);

	buf->dev = MKDEV(0, 0);

	buf->icanon = 0;

	buf->valid = 0;



	return buf;



err_buf: