Commit e13a7333 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

usb: acpi: Switch to use acpi_evaluate_dsm_typed() 



The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230310164129.21937-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f977caea

drivers/usb/core/usb-acpi.c

+4 −8
Original line number Diff line number Diff line
@@ -81,15 +81,11 @@ int usb_acpi_port_lpm_incapable(struct usb_device *hdev, int index) 
		return -ENODEV;

	}



	obj = acpi_evaluate_dsm(port_handle, &guid, 0,

				USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL);



	if (!obj)

		return -ENODEV;



	if (obj->type != ACPI_TYPE_INTEGER) {

	obj = acpi_evaluate_dsm_typed(port_handle, &guid, 0,

				      USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL,

				      ACPI_TYPE_INTEGER);

	if (!obj) {

		dev_dbg(&hdev->dev, "evaluate port-%d _DSM failed\n", port1);

		ACPI_FREE(obj);

		return -EINVAL;

	}